Added support of deflate algorithm in symbolic link decompression for zip archives #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariXanna
force-pushed
the
fix/#1508
branch
2 times, most recently
from
4b10462
to
51522ad
Compare
|
@antekone I would be grateful if you could review this PR, thanks |
|
In this PR you are removing |
|
zipx_lzma_uncompress_buffer() became useless with another approach introduced now. I don't think it is necessary to store unused code. Moreover, it was just a short extraction from zip_read_data_zipx_lzma_alone() and can be reconstructed easily if required again (it was code duplication to some extent and it is a good chance to eliminate it now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1508
Main idea of the change is taken from https://opensource.apple.com/source/libarchive/libarchive-72.140.1/libarchive/libarchive/archive_read_support_format_zip.c.auto.html and adapted to the implementation from #1434