Add support for rar5 sfx files #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFranklin13
force-pushed
the
rar5_sfx
branch
from
f420198
to
d45d87e
Compare
|
Hi, could you please provide a test for the PR? |
|
I'm having trouble creating an sfx archive with the official rar tool but if you can do so that would be great. |
|
Hi, I have created a test SFX with a licenced copy of WinRAR. |
JFranklin13
force-pushed
the
rar5_sfx
branch
3 times, most recently
from
ea0d9fa
to
cbf34df
Compare
|
@mmatuska the test was added |
mmatuska
requested changes
Nov 16, 2021
| rar5_signature(signature); | ||
|
|
||
| while (offset + window <= (1024 * 512)) { | ||
| const char *buff = __archive_read_ahead(a, offset + window, &bytes_avail); |
There was a problem hiding this comment.
Could you please wrap to 80 chars?
| } | ||
| p = buff + offset; | ||
| while (p + 8 < buff + bytes_avail) { | ||
| if (memcmp(p, signature, sizeof(signature)) == 0) |
There was a problem hiding this comment.
Could you please wrap to 80 chars?
| * like the RAR header. | ||
| */ | ||
| while (p + 8 < q) { | ||
| if (memcmp(p, signature, sizeof(signature)) == 0) { |
There was a problem hiding this comment.
Could you please wrap to 80 chars?
|
@antekone would you have some time to look at this PR? |
|
Ok, lets get it in for starters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1576