Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call CreateFileA and CreateFileW in Universal Windows Platform builds #1885

Merged
merged 2 commits into from Jul 13, 2023
Merged

Don't call CreateFileA and CreateFileW in Universal Windows Platform builds #1885

merged 2 commits into from Jul 13, 2023

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented May 26, 2023

@robUx4
Use CreateFile2 instead of CreateFileW on Win8+ builds
940ad21 
CreateFileW is not allowed in Universal Windows Platform (UWP) builds but
CreateFile2 is available. We could just enable this code for UWP but
it's probably to use it going forward so the code is properly tested on
both sides.
@robUx4
Disable CreateFileA calls in UWP builds
a38f94b 
Only CreateFile2 and CreateFileFromAppW are allowed.
@mmatuska mmatuska merged commit 9e1081b into libarchive:master Jul 13, 2023
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robUx4 @mmatuska