Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overflow checking in archive_entry_sparse_add_entry() #33

Merged
merged 1 commit into from Mar 30, 2013
Merged

Fix overflow checking in archive_entry_sparse_add_entry() #33

merged 1 commit into from Mar 30, 2013

Commits on Mar 16, 2013

  1. Fix overflow checking in archive_entry_sparse_add_entry() 

    gcc will optimize the overflow check x + y < 0 (assuming x, y >= 0)
into false, since signed integer overflow is undefined behavior in C.
Use a safe precondition check instead.
    @xiw
    xiw committed Mar 16, 2013
    Copy the full SHA
    bc533e5 View commit details
    Browse the repository at this point in the history