Fix scoping error with "disk" variable #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable named 'disk' inside the loop was hiding the variable named 'disk' at the outer level. The outer variable was never used, get rid of it. Move the call to archive_read_disk_set_standard_lookup(disk) inside the loop so that it Does What It Should.
|
Thanks for the correction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable named 'disk' inside the loop was hiding the variable named
'disk' at the outer level. The outer variable was never used, get rid
of it.
Move the call to archive_read_disk_set_standard_lookup(disk) inside the
loop so that it Does What It Should.
See this comment in #786.