-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
\h fallback messes up positioning #42
Comments
Sign-SaberWork is right- or middle-aligned? Duplicate of (the remaining sub-issue of) #16. |
|
Yeah, I’d just compared the \pos to the screenshot and deduced it was \an5 when you replied. You haven’t copied enough “Saber” lines to be completely sure, but it must be #16. |
those are the only lines with the SaberWork styles in the script. |
Yeah, that was a derp. I’m struggling to understand which line produces which part of the image. What I can say for sure is that the first line definitely has \fsp and thus definitely is misplaced as in #16. |
What happens in VSFilter:
What currently happens in libass:
Two things need to be done:
|
Interesting. I added this substitution not for fun though, but to avoid rendering issues with various scripts. But that was back in 2009, libass has changed a whole lot since then. |
\h is often used in typesetting purely for horizontal padding. This relies on its metrics being known. VSFilter uses the NBSP glyph directly and substitutes Arial if it does not exist in the given font. The previous commit dealt with the Arial substitution, so what remains now is only to use NBSP directly. This reverts commit 33a3ab2. This fixes libass#42.
\h is often used in typesetting purely for horizontal padding. This relies on its metrics being known. VSFilter uses the NBSP glyph directly and substitutes Arial if it does not exist in the given font. The previous commit dealt with the Arial substitution, so what remains now is only to use NBSP directly. This reverts commit 33a3ab2. This fixes libass#42.
\h is often used in typesetting purely for horizontal padding. This relies on its metrics being known. VSFilter uses the NBSP glyph directly and substitutes Arial if it does not exist in the given font. This commit adds the same behavior to libass. This does not make our font selection closer to VSFilter's in the general case. However, \h is particularly common and sensitive, so this commit fixes is at a special case. Part of this commit reverts commit 33a3ab2. Fixes libass#2. Fixes libass#42.
The \h issue is also very visible in JoJo’s (and probably Commie’s) JoJo episode 20 at 12:44. Also, sorry for the “referenced this issue from a commit” spam! ._. GitHub adds one every single time I push a rebased or reworded or very slightly modified commit. I wish it would just delete the previous “referenced” line when it does that. |
\h is often used in typesetting purely for horizontal padding. This relies on its metrics being known. VSFilter uses the NBSP glyph directly and substitutes Arial if it does not exist in the given font. This commit adds the same behavior to libass. This does not make our font selection closer to VSFilter's in the general case. However, \h is particularly common and sensitive, so this commit fixes is at a special case. Fixes libass#2. Fixes libass#42.
\h is often used in typesetting purely for horizontal padding. This relies on its metrics being known. VSFilter uses the NBSP glyph directly and substitutes Arial if it does not exist in the given font. This commit adds the same behavior to libass. This does not make our font selection closer to VSFilter's in the general case. However, \h is particularly common and sensitive, so this commit fixes it especially. Fixes libass#2. Fixes libass#42.
This looks to be fixed by @astiob's 2014 commit, or at least the sign looks pretty sensible now and I vaguely recall it being a fine mess: |
This comment was marked as outdated.
This comment was marked as outdated.
As tracked in #550, this probably depends on the |
libass:
![](https://user-images.githubusercontent.com/819638/78308939-68b6ef80-750f-11ea-9f93-e83a1d17f241.png)
xy-vs:
![d6e625c3e6121e698a695be388fb0565](https://user-images.githubusercontent.com/819638/78310652-2e038600-7514-11ea-8cd3-b7aee6f7acdc.jpg)
File is 9AD4509C
The text was updated successfully, but these errors were encountered: