Fix ass_set_cache_limits() to work with composite cache #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems sensible. |
astiob
reviewed
Dec 7, 2016
|
|
||
| size_t bitmap_cache, composite_cache; | ||
| if (bitmap_max) { | ||
| bitmap_cache = 1048576 * (size_t) bitmap_max; |
There was a problem hiding this comment.
It’s been asked on IRC that 1048576 should be made a macro here, perhaps named something like BITMAP_CACHE_SIZE_UNIT. I realize this commit doesn’t introduce this constant, but it seems like a good opportunity to name it and make it just a bit more obvious how the cache size is configured.
Previously was possible to set only bitmap_max_size, now requested memory amount is divided between bitmap_max_size and composite_max_size.
MrSmile
force-pushed
the
cache-limits
branch
from
f61a8c7
to
9f73250
Compare
astiob
approved these changes
Dec 28, 2016
|
(Merged in 3ba18f6.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've not tested this (does mpv have setting for libass cache size?) so people who knows software that relies on
ass_set_cache_limitsare welcomed.