Preliminary work ahead of threading support #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrSmile
approved these changes
Apr 23, 2024
libass/ass_render.c
Outdated
| @@ -76,6 +76,29 @@ static void text_info_done(TextInfo* text_info) | |||
| free(text_info->combined_bitmaps); | |||
| } | |||
|
|
|||
| static bool setup_render_context(RenderContext *state, ASS_Renderer *priv) | |||
There was a problem hiding this comment.
Maybe it's better to rename into render_context_init for uniformity?
TheOneric
approved these changes
Apr 23, 2024
astiob
approved these changes
Apr 23, 2024
libass/ass_compat.h
Outdated
| @@ -43,4 +43,15 @@ char *ass_strndup_fallback(const char *s, size_t n); // definition in ass_utils. | |||
| #define strndup ass_strndup_fallback | |||
| #endif | |||
|
|
|||
| #if defined(_WIN32) | |||
rcombs
force-pushed
the
threading-extracts
branch
from
7c7fa7b
to
8b1cfb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #636. These are infrastructural changes that don't directly involve multithreading, but either were necessary for its implementation or came about during the work. Best reviewed commit-by-commit.