New Birthdays Calendar subscription on page load #153

abyssox · 2015-09-05T05:47:57Z

Currently using v1.0.9. (Don't know if its relevant: Contact+ v1.0.5).

Everytime i visit the Calendar page or refresh the page, i get one more Birhdays Calendar item.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26467288-new-birthdays-calendar-subscription-on-page-load?utm_campaign=plugin&utm_content=tracker%2F19394737&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F19394737&utm_medium=issues&utm_source=github).

libasys · 2015-09-05T06:04:36Z

you have to delete all birthdays subscription and update contacts+ to 1.0.6 (current master)

abyssox · 2015-09-05T06:25:21Z

Contact+ was already current master. Sry, thought it was v1.0.5.
Anyway i deleted all subscriptions but the issue still exists. On every page load i get one more Birthdays subscription.

libasys · 2015-09-05T07:41:49Z

have you access to your database? if yes look on the oc_cldrplus_calendar table! the uri of the birthday calendar should be "birthday_{username}" means for example birthday_tester! and what happend on your installation it increments the calendar to birthday_tester1 and so on!

abyssox · 2015-09-06T05:05:51Z

Yes i see it.
birthday_mario
birthday_mario1
birthday_mario11
birthday_mario111

How can we fix this or where does it come from?

libasys · 2015-09-06T08:09:55Z

can you retest current master, i have done a commit!
ec9dafc
which database do you use?

abyssox · 2015-09-06T18:02:04Z

Hmm, unfortunately your fix doesn't work for me. Still have the issue.
I'm using MySQL 5.6.26 with PHP 5.6.12.

libasys · 2015-09-06T18:28:03Z

i have no problems something in error logs? have you deleted the other birthday cals?

syt3c · 2015-09-06T21:35:35Z

hey there,
same prob here (same behavior in the db). imported my calendar.ics in and every pagereload it clones the "birthdays_x". using contacs+1.0.7 and calendar+ 1.1.0
get some err in logs but don't know if its part of the problem:
Error PHP Array to string conversion at /www/htdocs/myowncloud.com/lib/private/template/functions.php#36

i think it came fromt the contacts+ ? deleted all calendars and its still came up ...

syt3c · 2015-09-06T21:39:59Z

me again ;)
deactivated contacts+ and no more birthday calendars coming up. hopefully helpful

libasys · 2015-09-06T21:41:34Z

no the error comes from the admin settings page itself! Please give me some Info about Environment like Webserver Database and so on! I have tested the New versions with MySQL and sqlite and both Works like expected! The actual versions of calendar+ and contacts+ are on my demo integrated and work like expected! http://demo81.libasyscloud.de

syt3c · 2015-09-06T21:51:22Z

i use oc @ all-inkl.com (hosting), PHP Version 5.5.26, MySQL 5.6.24.
yesterday i importet my contacts but somthing went wrong. deleted all contacts and today i looked at the calendar. still playing with it before it really get going :)

edit: activated the empty contcats+ app and the error starts again. in my logs (loglevel:all) there are some updatemsgs and that:
Debug DeleteOrphanedSharesJob 0 orphaned share(s) deleted 2015-09-06T23:52:18+02:00
Warning OCP\Share Sharing backend OCA\ContactsPlus\Share\Backend\Contact not registered, OCA\ContactsPlus\Share\Backend\Contact is already registered for cplcontact 2015-09-06T23:52:09+02:00
Warning OCP\Share Sharing backend OCA\ContactsPlus\Share\Backend\Addressbook not registered, OCA\ContactsPlus\Share\Backend\Addressbook is already registered for cpladdrbook 2015-09-06T23:52:09+02:00

libasys · 2015-09-06T22:17:08Z

Have you the normal contacts App. Activated?

abyssox · 2015-09-07T04:59:41Z

Yes, the normal contacts app is activated but i have no errors in the logfile.

Nemofly · 2015-09-07T08:48:39Z

Hello,
i have the same Problem. My System
OC 8.1.1-3
Newest MySQL version
Ubuntu 15.04
Calendar+ 1.1.0
Contacts+ 1.0.7
tasks+ 1.0.2
i have an testsystem where only Contacts+ Tasks+ and Calendar+ is activated.
The error only occures if i share a Calendar.
So i have an account "Backup". There i share the calendar to the account "Basti" if i log on in "Basti" and reload the calendar app every refresh one more birthday comes new.
Then i did a new user "Test" i log in an reload the calendar+ app. everything is fine.
If i share a calendar from Backup or Basti account and then login again in "Test" the same birthday error occures.
What can i do?
It was a fresh owncloud installation before!

libasys · 2015-09-07T09:13:59Z

i will investigate!

make birthday calendar name more unique, code cleanup not needed anymore search for birthday_

libasys · 2015-09-07T13:16:19Z

please retest current master of calendar+

Nemofly · 2015-09-07T13:51:55Z

I will test it later and Send Feedback

Von meinem iPhone gesendet

Am 07.09.2015 um 15:16 schrieb Sebastian Döll notifications@github.com:

please retest current master of calendar+

—
Reply to this email directly or view it on GitHub.

Nemofly · 2015-09-07T14:44:49Z

So now i tested it, and for me the problem is solved.
only one Birthday is shown.
if you have more after the update delete every Birthday, and after a lot reloads you only have one.
i think it is perfekt now!

syt3c · 2015-09-07T17:04:49Z

Tested the new master. Still the same prob with birthdays..
installed the current contacts+ from github too. but it looks like its a prob with my user. currently I only have two users (john and mike). the 2nd has no problems (john). I deleted the first user but the problem came back as soon as I add a user with the old (mike) name !?

the mysql table looks now like this:
bdaycpltocal_john
bdaycpltocal_mike
bdaycpltocal_mike1
bdaycpltocal_mike11

in the apps is no data stored and both have been completely cleared and freshly installed.

edit: have added a third user and has the same "birthday"-problem

Nemofly · 2015-09-07T19:26:01Z

Hey,
Maybee Export your hole calendar and Then Delete all MySQL tables with calendarplus Inside. I think there should be 3 tables.
First deactivate calendarplus. Delete the calendarplus. And Then Try it completly new?

Von meinem iPhone gesendet

Am 07.09.2015 um 19:04 schrieb syt3c notifications@github.com:

Tested the new master. Still the same prob with birthdays..
installed the current contacts+ from github too. but it looks like its a prob with my user. currently I only have two users (john and mike). the 2nd has no problems (john). I deleted the first user but the problem came back as soon as I add a user with the old (mike) name !?

the mysql table looks now like this:
bdaycpltocal_john
bdaycpltocal_mike
bdaycpltocal_mike1
bdaycpltocal_mike11

in the apps is no data stored.

—
Reply to this email directly or view it on GitHub.

syt3c · 2015-09-07T21:23:42Z

maybe it was an error in the table. I have reinstalled owncloud on my space and now its working :) Added contacts+ after calendar+ and only 1 birthday came up.

playtime.. ermm no.. bedtime :p

Edit:
clapped too early. 1st user works fine, the calender of the second dublicates the birthday-tabs again :( as i said, fresh install w/o data.

abyssox · 2015-09-08T07:00:14Z

Same here. I tested the following things:

deleted all duplicate Birthday Calendars -> New Birthday Calendar subscription after each reload
deleted Calender+ Apps folder, database tables and installed Calendar+ new from latest git master -> New Birthday Calendar subscription after each reload
created new test user, logged in, opened Calendar+ Page -> New Birthday Calendar subscription after each reload

@libasys i can provide you a test account on my owncloud instance if needed.

libasys · 2015-09-08T09:15:41Z

yes please!

abyssox · 2015-09-08T09:28:34Z

@libasys Email is on the way
Please let me know if you need any more information

libasys · 2015-09-08T10:37:21Z

@calis2002 do you use the github version of contacts+? if i add a birthday in your cloud then this isn't displayed on the calendar+ so i think you have an old version of contacts+!

abyssox · 2015-09-08T10:58:41Z

Yes, i use the current master version of Contact+ and Calendar+

libasys · 2015-09-08T11:02:23Z

something in your error logs on the admin settings page?

abyssox · 2015-09-08T11:06:28Z

Unfortunately no

libasys · 2015-09-08T12:12:32Z

please retest current master this fix is included 863073c

syt3c · 2015-09-08T16:40:26Z

tested the current master (18:00h) -> same prob.

edit: my contactsplus-master is from yesterday ~18:30. tested the creation of a birthday-event in the contacts and yep, it will not appear in the Calendar.

abyssox · 2015-09-08T18:14:57Z

Yes, problem still exists, even with 863073c

hoelli · 2015-09-12T16:40:33Z

Hi!
My help will be little, probably, since I'm quite a beginner... I just wanted to state, that I have the same problem. I got the newest versions from apps.owncloud.com (not github).
New birthday calendars are created like described above, but in my case not even one birthday from contacts+ appears in calendar+, but I have quite a lot of birthdays stored in my contacts...

I would be very appreciated, if you find a solution for this! :)

If I can do anything to help finding a solution, please let me know.

BR,
Johannes

Nemofly · 2015-09-15T06:05:42Z

Hey,

i´ve got still the same Problem with newest Calendar+ Contacts+ and Tasks+.

Still in a new and fresh instance of owncloud.

Mr-HeBo · 2015-09-18T11:59:07Z

Hey,

me too. There are no dates of birth displayed (red).
Each time you open Calendar Plus, an additional birthday calendar (*user_111, *user_1111) is displayed.

OC 8.1.3 (shared hosts) / Contacts Plus 1.0.9 / Calendar Plus 1.1.1 / PHP 5.6.12

godfuture · 2015-09-18T16:33:51Z

I have the same issue.

OC 8.1.3
Calendar+ 1.1.1
Contacts+ 1.0.9

libasys · 2015-09-19T12:40:41Z

Important, please add more information about database and which php version is in use!
Thanks!

rolapp · 2015-09-19T23:07:12Z

The error must in the calendarcontroller.php in this funktion or calling this funktion.

/**
     * @brief Gets the data of one calendar
     * @param string $uri
     * @return associative array
     */
    public function checkBirthdayCalendarByUri($uri) {
        $calendarInfo = $this->calendarDB->findByUri($uri);

        if($calendarInfo !== null){
            return $calendarInfo['id'];
        }else{
            $newCalId = $this->add($this->userId,$uri,'VEVENT,VTODO,VJOURNAL',null,0,'#C2F9FC',1,'',0);
            CalendarCalendar::editCalendar($newCalId, (string) $this->l10n->t('Birthdays'));

            return $newCalId;
        }

    }

The if part is never running the else part with take a new birthday table. I have comment it out a new birthday calender will not create. I think the variable $calendarInfo is every time null. This is the reason of import errors.

rolapp · 2015-09-20T12:43:52Z

Good News!

I have found the solution. Large and small character in usernames!

Birthday calendar from horst is working very well include share the birthday calendar.
Birthday calendar from Steffen have this error. Change the uri from bdaycpltocal_steffen in bdaycpltocal_Steffen. This is also working very well

libasys · 2015-09-20T15:15:39Z

ah perfect now i know the problem! if i check for existing users, i have to use the function to "strtolower"!
Many thanks! good work! next version comes with the bugfix!

Mr-HeBo · 2015-09-20T16:42:47Z

Yes! Thanks rolapp.
The workaround - changing "uri" - works. The birthdays are now displayed and there is no new birthday calendar "**user1xx"!

Nemofly · 2015-09-20T22:28:46Z

Perfect!!
That´s it!
Thanks a lot!! ;)

sonst-was · 2015-09-23T13:38:22Z

According to the change log on apps.owncloud.com this issue has been fixed in 1.1.0 (I dont see that release on github, so I cant verify the dates).

Using owncloud 8.1.3 with Calendar+ 1.1.1 and Contacts 1.0.9 I still have this issue

libasys · 2015-09-24T10:13:24Z

fix for this issue comes today!

abyssox · 2015-09-28T06:15:40Z

@rolapp Thanks! That worked for me too.
As soon as the fix is committed i will close the issue ;)

syt3c · 2015-10-01T12:32:59Z

nice +1

godfuture · 2015-10-28T14:00:28Z

Birthdays still now working for me, when will there be a next contactsplus release so that I could update and be happy?

Cheers

godfuture · 2015-11-30T16:31:21Z

Is it possible to downgrade to the default calendar app? I mean, is the export of calendarplus compatible with calendar default app? This issue drives me nuts and no commits done for long time now.

JBScoutBerlin · 2015-12-01T03:34:30Z

@godfuture: maybe there will ne no new commits for a longer time. And yes, you can get back to the dedault calebdar app as long as you export your calendard(s) as ICS-file, disable calendar+, activate the default app and import your exported ICS-file(s). Operating on SQL-server-level will not work.

libasys added bug in progress labels Sep 7, 2015

libasys added a commit that referenced this issue Sep 7, 2015

fix for #153

0497b92

make birthday calendar name more unique, code cleanup not needed anymore search for birthday_

abyssox mentioned this issue Oct 23, 2015

Birthday calendar keeps subscribing #190

Closed

New Birthdays Calendar subscription on page load #153

New Birthdays Calendar subscription on page load #153

Comments

abyssox commented Sep 5, 2015 • edited by libasys

libasys commented Sep 5, 2015

abyssox commented Sep 5, 2015

libasys commented Sep 5, 2015

abyssox commented Sep 6, 2015

libasys commented Sep 6, 2015

abyssox commented Sep 6, 2015

libasys commented Sep 6, 2015

syt3c commented Sep 6, 2015

syt3c commented Sep 6, 2015

libasys commented Sep 6, 2015

syt3c commented Sep 6, 2015

libasys commented Sep 6, 2015

abyssox commented Sep 7, 2015

Nemofly commented Sep 7, 2015

libasys commented Sep 7, 2015

libasys commented Sep 7, 2015

Nemofly commented Sep 7, 2015

Nemofly commented Sep 7, 2015

syt3c commented Sep 7, 2015

Nemofly commented Sep 7, 2015

syt3c commented Sep 7, 2015

abyssox commented Sep 8, 2015

libasys commented Sep 8, 2015

abyssox commented Sep 8, 2015

libasys commented Sep 8, 2015

abyssox commented Sep 8, 2015

libasys commented Sep 8, 2015

abyssox commented Sep 8, 2015

libasys commented Sep 8, 2015

syt3c commented Sep 8, 2015

abyssox commented Sep 8, 2015

hoelli commented Sep 12, 2015

Nemofly commented Sep 15, 2015

Mr-HeBo commented Sep 18, 2015

godfuture commented Sep 18, 2015

libasys commented Sep 19, 2015

rolapp commented Sep 19, 2015

rolapp commented Sep 20, 2015

Good News!

libasys commented Sep 20, 2015

Mr-HeBo commented Sep 20, 2015

Nemofly commented Sep 20, 2015

sonst-was commented Sep 23, 2015

libasys commented Sep 24, 2015

abyssox commented Sep 28, 2015

syt3c commented Oct 1, 2015

godfuture commented Oct 28, 2015

godfuture commented Nov 30, 2015

JBScoutBerlin commented Dec 1, 2015

abyssox commented Sep 5, 2015 •

edited by libasys