Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorted neighbor list #50

Open
pastewka opened this issue Sep 9, 2020 · 3 comments
Open

Sorted neighbor list #50

pastewka opened this issue Sep 9, 2020 · 3 comments
Labels

Comments

@pastewka
Copy link
Collaborator

pastewka commented Sep 9, 2020

The neighbor list is currently sorted by first index only, it may be beneficial for some applications to have a fully sorted neighbor list. This would make neighbor list construction slower, but only slightly so. Any opinions on this?

@jameskermode
Copy link
Member

Maybe optional and defaulting to not sorting?

@griessej
Copy link
Contributor

griessej commented Sep 9, 2020

I agree with James. If this is needed, it should be passed explicitly by keyword. Applications that do not need this will not suffer any performance loss.

@pastewka
Copy link
Collaborator Author

pastewka commented Sep 9, 2020

That would be an option. I'll look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants