Merge pull request #226 from evoskuil/version3

Remove unnecessary const on `operator const bool() const`.
libbitcoin · Apr 2, 2021 · 46f8427 · 46f8427
2 parents f4ae48d + 52f36d4
commit 46f8427
Show file tree

Hide file tree

Showing 10 changed files with 13 additions and 13 deletions.
diff --git a/.appveyor.yml b/.appveyor.yml
@@ -15,16 +15,16 @@ environment:
   matrix:
     - configuration: StaticDebug
       platform: x64
-      BOOST_UNIT_TEST_OPTIONS: "--run_test=authenticator_tests,certificate_tests,context_tests,frame_tests,identifiers_tests,message_tests,poller_tests,socket_tests,worker_tests --show_progress=no --detect_memory_leak=0 --report_level=no --build_info=yes"
+      BOOST_UNIT_TEST_OPTIONS: "--run_test=* --show_progress=no --detect_memory_leak=0 --report_level=no --build_info=yes"
     - configuration: StaticRelease
       platform: x64
-      BOOST_UNIT_TEST_OPTIONS: "--run_test=authenticator_tests,certificate_tests,context_tests,frame_tests,identifiers_tests,message_tests,poller_tests,socket_tests,worker_tests --show_progress=no --detect_memory_leak=0 --report_level=no --build_info=yes"
+      BOOST_UNIT_TEST_OPTIONS: "--run_test=* --show_progress=no --detect_memory_leak=0 --report_level=no --build_info=yes"
     - configuration: StaticDebug
       platform: Win32
-      BOOST_UNIT_TEST_OPTIONS: "--run_test=authenticator_tests,certificate_tests,context_tests,frame_tests,identifiers_tests,message_tests,poller_tests,socket_tests,worker_tests --show_progress=no --detect_memory_leak=0 --report_level=no --build_info=yes"
+      BOOST_UNIT_TEST_OPTIONS: "--run_test=* --show_progress=no --detect_memory_leak=0 --report_level=no --build_info=yes"
     - configuration: StaticRelease
       platform: Win32
-      BOOST_UNIT_TEST_OPTIONS: "--run_test=authenticator_tests,certificate_tests,context_tests,frame_tests,identifiers_tests,message_tests,poller_tests,socket_tests,worker_tests --show_progress=no --detect_memory_leak=0 --report_level=no --build_info=yes"
+      BOOST_UNIT_TEST_OPTIONS: "--run_test=* --show_progress=no --detect_memory_leak=0 --report_level=no --build_info=yes"
 
 matrix:
   fast_finish: true

diff --git a/include/bitcoin/protocol/zmq/certificate.hpp b/include/bitcoin/protocol/zmq/certificate.hpp
@@ -43,7 +43,7 @@ class BCP_API certificate
     certificate(const config::sodium& private_key);
 
     /// True if the certificate is valid.
-    operator const bool() const;
+    operator bool() const;
 
     /// The public key base85 text.
     const config::sodium& public_key() const;

diff --git a/include/bitcoin/protocol/zmq/context.hpp b/include/bitcoin/protocol/zmq/context.hpp
@@ -45,7 +45,7 @@ class BCP_API context
     virtual ~context();
 
     /// True if the context is valid and started.
-    operator const bool() const;
+    operator bool() const;
 
     /// The underlying zeromq context.
     void* self();

diff --git a/include/bitcoin/protocol/zmq/frame.hpp b/include/bitcoin/protocol/zmq/frame.hpp
@@ -47,7 +47,7 @@ class BCP_API frame
     virtual ~frame();
 
     /// True if the construction was successful.
-    operator const bool() const;
+    operator bool() const;
 
     /// True if there is more data to receive.
     bool more() const;

diff --git a/include/bitcoin/protocol/zmq/socket.hpp b/include/bitcoin/protocol/zmq/socket.hpp
@@ -80,7 +80,7 @@ class BCP_API socket
     virtual bool stop();
 
     /// True if the socket is valid.
-    operator const bool() const;
+    operator bool() const;
 
     /// The underlying zeromq socket.
     void* self();

diff --git a/libbitcoin-protocol-test_runner.sh b/libbitcoin-protocol-test_runner.sh
@@ -9,7 +9,7 @@
 # Define tests and options.
 #==============================================================================
 BOOST_UNIT_TEST_OPTIONS=\
-"--run_test=authenticator_tests,certificate_tests,context_tests,frame_tests,identifiers_tests,message_tests,poller_tests,socket_tests,worker_tests "\
+"--run_test=* "\
 "--show_progress=no "\
 "--detect_memory_leak=0 "\
 "--report_level=no "\

diff --git a/src/zmq/certificate.cpp b/src/zmq/certificate.cpp
@@ -97,7 +97,7 @@ bool certificate::create(config::sodium& out_public,
     return false;
 }
 
-certificate::operator const bool() const
+certificate::operator bool() const
 {
     return public_;
 }

diff --git a/src/zmq/context.cpp b/src/zmq/context.cpp
@@ -74,7 +74,7 @@ bool context::stop()
     ///////////////////////////////////////////////////////////////////////////
 }
 
-context::operator const bool() const
+context::operator bool() const
 {
     return self_ != nullptr;
 }

diff --git a/src/zmq/frame.cpp b/src/zmq/frame.cpp
@@ -67,7 +67,7 @@ bool frame::initialize(const data_chunk& data)
     return true;
 }
 
-frame::operator const bool() const
+frame::operator bool() const
 {
     return valid_;
 }

diff --git a/src/zmq/socket.cpp b/src/zmq/socket.cpp
@@ -190,7 +190,7 @@ bool socket::stop()
     return true;
 }
 
-socket::operator const bool() const
+socket::operator bool() const
 {
     return self_ != nullptr;
 }