Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix -Wtype-limits warning. #999

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Fix -Wtype-limits warning. #999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions include/bitcoin/bitcoin/impl/machine/operation.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,6 @@ inline bool operation::is_positive(opcode code)
inline bool operation::is_reserved(opcode code)
{
BC_CONSTEXPR auto op_186 = static_cast<uint8_t>(opcode::reserved_186);
BC_CONSTEXPR auto op_255 = static_cast<uint8_t>(opcode::reserved_255);

switch (code)
{
Expand All @@ -316,8 +315,7 @@ inline bool operation::is_reserved(opcode code)
case opcode::reserved_138:
return true;
default:
const auto value = static_cast<uint8_t>(code);
return value >= op_186 && value <= op_255;
return static_cast<uint8_t>(code) >= op_186;
}
}

Expand Down