Allow KernelResolver to load only kallsyms or just the kernel image. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue libbpf#7 mentioned that the BlazeSym doesn't resolve any address in the kernel space if a kernel image is not given or installed in the system. KernelResolver required both kallsyms and a kernel image to create itself successfully. However, the resolver should at least partially work even with only kallsyms. Signed-off-by: Kui-Feng Lee <kuifeng@fb.com>
anakryiko
approved these changes
Sep 23, 2022
| let ksymresolver = cache_holder.get_ksym_cache().get_resolver(kallsyms)?; | ||
| let kernelresolver = ElfResolver::new(kernel_image, 0, cache_holder)?; | ||
| let ksymresolver = cache_holder.get_ksym_cache().get_resolver(kallsyms); | ||
| let kernelresolver = ElfResolver::new(kernel_image, 0, cache_holder); |
There was a problem hiding this comment.
naming nit. It's not clear what's the difference between ksymresolver and kernelresolver, tbh. maybe at least call kernelresolve an kelfresolver or something along those lines to point out that it's relying on ELF file?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #7 mentioned that the BlazeSym doesn't resolve any address in the kernel space if a kernel image is not given or installed in the system. KernelResolver required both kallsyms and a kernel image to create itself successfully. However, the resolver should at least partially work even with only kallsyms.
Signed-off-by: Kui-Feng Lee kuifeng@fb.com