Eliminate unnecessary file open in process symbolization path #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using process symbolization, we instantiate an ElfParser object to calculate the address given a file offset. When we then later attempt to symbolize said address, we end up creating another ElfParser instance. That's plain unnecessary work. With this change we instantiate an ELF resolver using our file caching infrastructure from the get-go, which means that we do not end up opening the file in question twice and any already parsed ELF related data structure will just be reused. Refs: libbpf#511 Reported-by: r1viollet <erwan.viollet@datadoghq.com> Signed-off-by: Daniel Müller <deso@posteo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using process symbolization, we instantiate an ElfParser object to calculate the address given a file offset. When we then later attempt to symbolize said address, we end up creating another ElfParser instance. That's plain unnecessary work.
With this change we instantiate an ELF resolver using our file caching infrastructure from the get-go, which means that we do not end up opening the file in question twice and any already parsed ELF related data structure will just be reused.
Refs: #511
Reported-by: r1viollet erwan.viollet@datadoghq.com