Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Codecov file annotations #77

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

danielocfb
Copy link
Collaborator

We are seeing loads of code coverage annotations on pull requests for files that weren't even touched by said PR, e.g., here. This change introduces a configuration that hopefully 1 disables the feature.

We are seeing loads of code coverage annotations on pull requests for
files that weren't even touched by said PR, e.g., [here][0].
This change introduces a configuration that hopefully [1] disables the
feature.

[0]: libbpf@57522fc
[1]: https://docs.codecov.com/docs/github-checks#disabling-github-checks-patch-annotations-via-yaml

Signed-off-by: Daniel Müller <deso@posteo.net>
@danielocfb
Copy link
Collaborator Author

I created a pull request against my own fork and did no longer see those annotations with this change present.

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c4a7ab8) 68.76% compared to head (71787ff) 68.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   68.76%   68.76%           
=======================================
  Files          13       13           
  Lines        4392     4392           
=======================================
  Hits         3020     3020           
  Misses       1372     1372           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@anakryiko anakryiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for a quick "fix"!

@danielocfb danielocfb merged commit dfe722a into libbpf:master Mar 14, 2023
@danielocfb danielocfb deleted the topic/codecov-annotations branch March 20, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants