Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: xdppass: Use libbpf-cargo build script #29

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

danobi
Copy link
Member

@danobi danobi commented May 30, 2021

Build script is better than cargo plugin b/c you can't forget to run the
skeleton generation step.

Build script is better than cargo plugin b/c you can't forget to run the
skeleton generation step.
@danobi
Copy link
Member Author

danobi commented May 30, 2021

cc @chenhengqi

@chenhengqi
Copy link
Contributor

It looks good.

One small question, the current implementation use relative path rather than CARGO_MANIFEST_DIR, does it works in both workspace dir and crate dir?

@danobi
Copy link
Member Author

danobi commented May 31, 2021

One small question, the current implementation use relative path rather than CARGO_MANIFEST_DIR, does it works in both workspace dir and crate dir?

It should work. https://doc.rust-lang.org/cargo/reference/build-scripts.html says:

In addition to environment variables, the build script’s current directory is the source directory of the build script’s package.

@danobi
Copy link
Member Author

danobi commented Jun 3, 2021

@anakryiko ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants