Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid clobbering CFGF_RESET when cfg_setmulti fails #135

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Avoid clobbering CFGF_RESET when cfg_setmulti fails #135

merged 2 commits into from
Mar 18, 2020

Commits on Mar 17, 2020

  1. Add test triggering internal state change when cfg_setmulti fails 

    Signed-off-by: Peter Rosin <peda@axentia.se>
    @peda-r
    peda-r committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    0988652 View commit details
    Browse the repository at this point in the history

  2. Make cfg_setmulti revert the reset flag on failure 

    It is desirable to fail gracefully and leave the configuration
unaffected by imperfect input. Remember that cfg_setmulti is the
heart of the cli example and needs to fail as gracefully as
possible since it is used to parse end user input.

Signed-off-by: Peter Rosin <peda@axentia.se>
    @peda-r
    peda-r committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    2c5cb82 View commit details
    Browse the repository at this point in the history