Abort on init with duplicate options (i.e. options with the same name). #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's a little harsh to call abort() here. Why not use cfg_error() instead? |
|
There is an existing call to abort further down in the function. The situation is similar. The program is clearly not ok, so what good would it do to continue? |
|
But hey, why not use cfg_error instead? I'll update the branch in a moment |
Reported by Thomas Adam. Signed-off-by: Peter Rosin <peda@lysator.liu.se>
troglobit
added a commit
that referenced
this pull request
Nov 25, 2015
Abort on init with duplicate options (i.e. options with the same name). Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by Thomas Adam.
Signed-off-by: Peter Rosin peda@lysator.liu.se