Add function to create a new titled section

[jonasj76]

Example included.

[troglobit]

Great stuff, Jonas! Could you perhaps also add a unit test (see tests/) for this?

[peda-r]

I have been using:
char tmp[large_enough];
sprintf(tmp, "section-name \"%s\" {\n}", title);
cfg_parse_buf(cfg, tmp);

Which is kind of ugly...

[peda-r]

Hmm, I think attempts to add a pre-existing section should fail.
Maybe add a flags argument to get selective behavior?

[troglobit]

@peda-r Yeah this is cleaner.

Hmm, you're right and it also touches upon a related problem of mine. A global CFGF_OVERWRITE flag could control overwriting anything, good idea!

[peda-r]

I was thinking a flags argument to the new function, but I guess I don't care deeply about where the flags are specified...

[troglobit]

I just zoomed out a bit: a user that wants to add a section likely also want to be able to add other things as well.

[jonasj76]

Unit test added.
I agree that the default for adding a pre-existing section should fail. But should it be a flag or not to override this behaviour?

[troglobit]

@jonasj76 Thanks! :)

Yeah I think we should have a global flag, like this:

if (cfg->flags & CFGF_OVERWRITE)
    clear_current_opt()
if (set_value() fails)
     errno = EEXIST;
     return NULL;

or something, but I guess it could also be an option flag. I don't have a strong opinion on either one. With a global flag we could let it cascade down on all options on cfg_init() so the code only needs to check opt->flags ...

[jonasj76]

Added commit to fail when adding a pre-existing section.

[troglobit]

Awesome, thanks!

Like we discussed AFK today, adding a global and/or per-setting CFGF_OVERWRITE can be added later.