Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiperformTenSessionsGetTest Test Case Fails on macOS Nondeterministic #841

Open
COM8 opened this issue Oct 18, 2022 · 0 comments
Open

Comments

@COM8
Copy link
Member

COM8 commented Oct 18, 2022

Description

On macOS systems the MultiperformTenSessionsGetTest test case fails nondeterministic.
In case it fails, it gets an error indicating that the connection establishment failed inside curl.

This issue still exists, even in case we update to curl 7.85.0.

Example/How to Reproduce

Execute the MultiperformTenSessionsGetTest test case on macOS.
For this one first has to enable it again in the source code since I disabled it in #863 for macOS for now.

TEST(MultiperformGetTests, MultiperformTenSessionsGetTest) {
    const size_t sessionCount = 10;

    MultiPerform multiperform;
    Url url{server->GetBaseUrl() + "/hello.html"};
    for (size_t i = 0; i < sessionCount; ++i) {
        std::shared_ptr<Session> session = std::make_shared<Session>();
        session->SetUrl(url);
        multiperform.AddSession(session);
    }

    std::vector<Response> responses = multiperform.Get();

    EXPECT_EQ(responses.size(), sessionCount);
    for (Response& response : responses) {
        EXPECT_EQ(std::string{"Hello world!"}, response.text);
        EXPECT_EQ(url, response.url);
        EXPECT_EQ(std::string{"text/html"}, response.header["content-type"]);
        EXPECT_EQ(200, response.status_code);
        EXPECT_EQ(ErrorCode::OK, response.error.code);
    }
}

Possible Fix

Unknown.

Where did you get it from?

GitHub (branch e.g. master)

Additional Context/Your Environment

  • OS: macOS 12
  • Version: 1.9.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant