-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use relative name instead #1
Comments
It appears to be a safe change while maintaining backward compatibility for Caddy.
|
Apparently, my understanding was wrong. Backward compatibility may not be maintained. The old Certmagic (with Caddy 2.3.0) request the record looks like this:
The zone is FQDN, but the name is not FQDN (no trailing dot). Because of this, once I simply pass those values to The new Certmagic (with latest upstream Caddy) request looks like this:
If the It is difficult to satisfy both record with the same code. When the record name is I have to choice dropping backword compatibility or dropping the feature to handle the record that have trailing doubled domain name. But I think follow |
I think I understood it wrong again 🤔 It seems that Cloudflare absorbs minor differences in the request payload on the API side. On cloudflare, The following three request payloads all yielded the same result.
This means that backward compatibility about new libdns is preserved for Cloudflare provider, while Azure's API interprets requests as strictly relative names, which is different from Cloudflare. ...and this is a little off-topic, however, I think this may also be the cause of the problem that the latest certmagic can't handle www.example.com.example.com well with Cloudflare. |
libdns/libdns#12
The text was updated successfully, but these errors were encountered: