libdns/desec: Bump libdns version to v0.2.2

[Monviech]

libdns/desec: Bump libdns version to v0.2.2

I am building this plugin together with cloudflare. Since cloudflare does an indirect upgrade of the libdns version, the build fails.

This PR fixes the build as single module, or together with cloudflare.

[znkr]

Thanks for the pull request. I left a quick comment and will read up on the libdns changes. I didn't know there was a new release of libdns and I want to understand if I need to do a new release for this provider too.

Edit: There are a number of changes in the other branch that should be ported over before I can release a new version and I should test that everything works. I'll try to find some time to do that, but that's not going to block this PR.

[Monviech]

Hello, thanks for looking into it. :)

As reference, this is how the netlify maintainer handled it. They have created a new version:

libdns/netlify#4
caddy-dns/netlify@eaa9514

[znkr]

I ported the changes over and ran tests to make sure everything still works. I hope I got it right, but I am not 100% certain. I also included the version bump in those changes and mentioned you as a co-author. The reason, I didn't take this PR directly is my open question on the provider.go file.

[Monviech]

Hey there, I tried the build out to give some feedback.

I just tried the build with your patched version, and it failed. I had included the fix for the int/uint in the PR when libdns 0.2.2 is used. Now I get the build error because I think it didn't make it into this new version.

/root/go/pkg/mod/github.com/libdns/desec@v0.2.3/provider.go:486:14: cannot use int(prio) (value of type int) as uint value in struct literal

Building it with my custom patch still works:

https://github.com/opnsense/tools/blob/2d12f9a27cf08b25fdcdb60beae6569ae601f6c5/config/24.1/make.conf#L111-L112

Sorry >~<

[znkr]

Can you try again with v0.2.4?

I think your mixing desec v0.2.3 with libdns v0.2.2, that's why you're getting that error. I don't know what you did locally to be the uint conversion, but I suspect that you based your change on the v0.2.1-compat branch. I actually started with developing against v0.2.2 before it was released and then created the v0.2.1-compat branch targeting v0.2.1. This makes it all very, very confusing and the fact that I tried to mimic the libdns version, but have had to release patch versions doesn't help. Sorry for the confusion.

[Monviech]

I thought I could delete the reference for libdns/desec from the build since it will be pulled by the dependency of caddy-dns/desec. But since caddy-dns/desec was not updated, it depends on an older version of libdns/desec.

This build works: (building with libdns/desec v0.2.4 as suggested)

xcaddy build \
--with github.com/caddy-dns/cloudflare@44030f9306f4815aceed3b042c7f3d2c2b110c97 \
--with github.com/caddy-dns/desec@e1e64971fe34c29ce3f4176464adb84d6890aa50 \
--with github.com/libdns/desec@a279f344b3a94dba7ef810dff5e3db31667957ad

This build fails: (since it pulls an old libdns/desec dependency)

xcaddy build \
--with github.com/caddy-dns/cloudflare@44030f9306f4815aceed3b042c7f3d2c2b110c97 \
--with github.com/caddy-dns/desec@e1e64971fe34c29ce3f4176464adb84d6890aa50