Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config initialisation is wrong #13

Closed
mr-karan opened this issue Jul 15, 2022 · 1 comment · Fixed by #15
Closed

Config initialisation is wrong #13

mr-karan opened this issue Jul 15, 2022 · 1 comment · Fixed by #15

Comments

@mr-karan
Copy link

mr-karan commented Jul 15, 2022

If there are no specific AWS static keys provided to the Provider struct, it results in:

operation error Route 53: ListHostedZonesByName, failed to sign request: failed to retrieve credentials: static credentials are empty

However, valid AWS keys are present in the enviornment:

AWS_ACCESS_KEY_ID=
AWS_SECRET_ACCESS_KEY=
AWS_SESSION_TOKEN=

The config.LoadDefaultConfig is sufficient to read these keys from the environment, so no special initialization is needed.

The NewStaticCredentialsProvider should only be chained if AccessKeyId in Provider is a non empty value.

@aymanbagabas
Copy link
Collaborator

Thanks for reporting this. I think this is a valid issue, will fix this soon.

aymanbagabas added a commit that referenced this issue Jul 19, 2022
ignore static credentials when they are not provided

Fixes: #13
aymanbagabas added a commit that referenced this issue Jul 19, 2022
ignore static credentials when they are not provided

Fixes: #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants