Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMakeLists file for CMake build #8

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Conversation

JaLooNz
Copy link

@JaLooNz JaLooNz commented Jun 10, 2024

  • Add CMakeLists file for CMake build for libraries and applications
  • Various options are disabled instead of enable
  • ECDH functionality will break self-test application

-Add CMakeLists file for CMake build for libraries and applications
-Various options are disabled instead of enable
-ECDH functionality will break self-test application
@rben-dev
Copy link

Hi @JaLooNz

Thanks for your interest in libecc and your PR!

I have small remarks before merging this:

  • First, I cannot see the self tests binaries produced after cmake and make are called. Only the static libraries are built. I might have missed something?
  • Also, as I can see the PLATFORM_WORD_SIZE is always set to 32, but the best option would be if it is not defined to let the library decide itself (as in the header a self detection is made to fit the compilation platform with the best size).

Thanks in advance,

-DEfault build ec-self-tests and ec-utils
-Add detection for CMAKE_GENERATOR and CMAKE_CL_64 (working for x86 and x86_64 windows builds using Visual Studio)
@JaLooNz
Copy link
Author

JaLooNz commented Jun 14, 2024

Hi,
CMakeLists updated to address the above issues.
Additionally, also fixed ECDH options due to missing source for executable.

@rben-dev rben-dev merged commit e6b63c4 into libecc:master Jun 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants