Improve the .one()
and .all()
methods
#71
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The starting point of this branch was that the
.one()
and.all()
methods currently choke on queries likeSELECT values FROM something
, because they assume that avalues
attribute is a callable similar to thedict.values()
method. This is fixed by changing the condition fromhasattr(out, 'values')
tocallable(getattr(out, 'values', None))
, but while I was at it I also reorganized the code and added a few more tests.