Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS/2.yStrikeoutPosition is too low #58

Open
khaledhosny opened this issue Dec 2, 2022 · 1 comment
Open

OS/2.yStrikeoutPosition is too low #58

khaledhosny opened this issue Dec 2, 2022 · 1 comment

Comments

@khaledhosny
Copy link

Describe the bug

The next version of LibreOffice will use the strikeout size and position provided by the fonts in the OS/2 table when drawing strikeout line. The offset values provided by liberation fonts seem to be too low, and at low resolution the strikeout position is essentially on the baseline. I think the position in the font is calculated from the bottom of the strikeout stroke, but the spec states that it should be from the top.

To Reproduce
See the test document and screenshots in https://bugs.documentfoundation.org/show_bug.cgi?id=152267

Expected behavior
The strikeout stroke should be at the same position as the em-dash or somwhat close to oy

Screenshots
Strikeout compared to em-dash:
image

Desktop (please complete the following information):

  • OS/Distro and Version: macOS 12.6.1
  • Liberation-Fonts Version: 2.1.4
  • Application Name & Version: LibreOffice 7.5
@khaledhosny
Copy link
Author

This seems to actually affect Liberation Serif Regular most, in other fonts the value seems to be OK.

khaledhosny added a commit to aliftype/liberation-fonts that referenced this issue Dec 2, 2022
Use the same position as the other fonts.

Fixes liberationfonts#58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant