Merge pull request #104 from saimn/fix-O3

Fix dangling pointer leading to unexpected behavior with -O3
liberfa · Mar 29, 2023 · c12b70e · c12b70e
2 parents e33ee55 + 43f4e4b
commit c12b70e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -1,3 +1,8 @@
+2.0.0.4 (unreleased)
+====================
+
+- Fix dangling pointer leading to unexpected behavior with ``-O3``.
+
 2.0.0.3 (2023-03-22)
 ====================
 

diff --git a/erfa/ufunc.c.templ b/erfa/ufunc.c.templ
@@ -556,6 +556,7 @@ static int ErfaUFuncTypeResolver(PyUFuncObject *ufunc,
 {
     int *types;
     PyArray_Descr **dtypes;
+    int types_array[NPY_MAXARGS];
 
     if (ufunc->userloops) {
         Py_ssize_t unused_pos = 0;
@@ -577,7 +578,6 @@ static int ErfaUFuncTypeResolver(PyUFuncObject *ufunc,
     }
     else {
         npy_intp j;
-        int types_array[NPY_MAXARGS];
 
         if (ufunc->ntypes != 1) {
             goto fail;