Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove numpy version constraint #122

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Remove numpy version constraint #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ requires = [
"setuptools",
"setuptools_scm>=6.2",
"jinja2>=2.10.3",
"numpy>=1.25,<2"
"numpy"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should still keep the minversion pin.

Suggested change
"numpy"
"numpy>=1.25"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just spent a good 5 minutes trying to understand why this lower bound wasn't present, so I'd argue that, if nothing else, having the pin would save some dev time :-)
Any way now that numpy 2.0 is imminent, the actual requirement will soon become >=2.0 (only way to support numpy 1 and 2). It might continue to just work if we don't have the pin, however it's important information that should be communicated to downstream packagers, who, as I understand, do not necessarily rely on pip to parse and install build time requirements.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it depends what the pin here is meant to communicate. To me, it always was the minimum version that one needs to build something that works in one's current environment. For that purpose, there is no special minimum version. The >= 2.0 is needed only if the goal is to build something that will work for many environments, i.e., the wheels. But for those we have full control anyway.

I guess my logic is that we use as few constraints as are needed for our purposes -- and we do not need any.

]
build-backend = 'setuptools.build_meta'
Loading