Make the build reproducible #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the Reproducible Builds effort [0] we noticed that pyerfa could not be built reproducibly. This is due to the documentation contained the current build date. This was originally filed in Debian as #964958 [1]. [0] https://reproducible-builds.org/ [1] https://bugs.debian.org/964958
|
Thanks @lamby |
bmwiedemann
reviewed
Jul 18, 2020
| @@ -41,6 +41,9 @@ | |||
|
|
|||
| project = 'PyERFA' | |||
| author = 'The PyERFA Developers' | |||
| build_date = datetime.utcfromtimestamp( | |||
| int(os.environ.get('SOURCE_DATE_EPOCH', time.time())) | |||
| ) | |||
| copyright = '2011–{0}, {1}'.format(datetime.utcnow().year, author) | |||
There was a problem hiding this comment.
shouldnt this use build_date.year here?
There was a problem hiding this comment.
thanks @bmwiedemann you are perfectly right.
I will fix it ASAP
There was a problem hiding this comment.
The original patch from Debian is unaffected - it was the version here that was copied incorrectly.
avalentino
added a commit
to avalentino/pyerfa
that referenced
this pull request
Jul 18, 2020
See also PR liberfa#45.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on the Reproducible Builds effort we noticed that pyerfa could not be built reproducibly. This is due to the documentation contained the current build date.
(This was originally filed in Debian as #964958.)