Suppression de la DAO #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prytoegrian
force-pushed
the
pry/noMoreDao
branch
from
f0c0f6e
to
3c24515
Compare
prytoegrian
force-pushed
the
pry/noMoreDao
branch
from
3c24515
to
13ff883
Compare
|
Autoreview / autotest puis merge. J'en ai besoin pour la PR de correction d'algo de MDP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oui… je sais… je l'ai mise puis je l'ai enlevé.
En soit, un DAO n'est pas une mauvaise idée, loin s'en faut, mais ça apporte une touche de complexité supplémentaire et quelques doublons assez disgracieux eu égard à l'application et son niveau de complexité. Aussi, je propose sa suppression, jusqu'au jour où elle sera absolument nécessaire ; dans l'intervalle nous pourrons profiter d'une application légère et plus facilement digérable (C'est un MVC nourri aux bonnes pratiques tout ce qu'il y a de plus standards).
Par contre, j'avoue m'y être bien mal pris, et le résultat est cette PR, assez volumineuse. Je ne savais pas comment m'y prendre pour faire des choses granulaires.