-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Déplacement des contrôleurs dans Tools #45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
075e2db
to
8bdc2bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suite aux PRs #40, #38 et #37, le « package by feature » n'était pas parfaitement adapté en pratique. En effet, ces PRs ont montré que l'on pouvait avoir une portée métier sur un élément (l'utilisateur) avec une route et donc un contrôleur différent. Appuyé sur la suite de #40, j'ai donc déplacé les contrôleurs dans le répertoire
Tools
, attendu qu'ils ne représentent pas un composant mais un moyen d'accès à ce composant, le tout en les auto-chargeant par le framework.Selon la ségrégation stricte newables / injectables, les contrôleurs avaient une mauvaise construction, ils dépendaient d'un newable, l'entité Utilisateur, pour vérifier les droits d'accès. J'ai donc dû déporter les contrôles d'accès à part, dans un middleware. Ça n'a rien de parfait mais on corrigera quand on aura un besoin plus grand.
Todo :