This repository has been archived by the owner on Jun 24, 2023. It is now read-only.
Added video and audio expando. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm lazy, so I just bunged them together. If a non-lazy programmer visits later, they might want to separate them for an improved user experience.
|
Sweet man! |
|
im gonna merge and fix your issues, this is an awesome PR. Sometime we gotta get this same support into the server-side post expandos. It feels wrong when comments have more features than posts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm lazy, so I just bunged them together. If a non-lazy programmer visits later, they might want to separate them for an improved user experience.
I also missed out a load of formats, like WAV and FLAC. This should be treated as a kludge or a proof of concept; it's better than what we had before (no support for flat video / audio files), but should be improved when free time is available.