Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep: XMLReader support https://github.com/gramps-project/gramps/blob/master/data/grampsxml.dtd format for exporting to GRAMPS XML format from people objects in eloquent/laravel database (✓ Sandbox Passed) #18

Merged

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Mar 13, 2024

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement

Description

This pull request includes changes to the README.md, src/Services/XmlReader.php, and src/XmlWriter.php files. The changes involve adding support for the grampsxml.dtd format when exporting to the GRAMPS XML format from people objects in an eloquent/laravel database. The XmlReader service now includes mappings for additional attributes defined in the grampsxml.dtd format. The XmlWriter service now includes a method to validate XML content against the grampsxml.dtd format.

Summary

  • Updated README.md to include an example of using the XmlWriter service to write to an XML file in the GRAMPS XML format and validate the XML content against the grampsxml.dtd format.
  • Added mappings for additional attributes defined in the grampsxml.dtd format in the XmlReader service.
  • Added a method to validate XML content against the grampsxml.dtd format in the XmlWriter service.

Fixes #14.


🎉 Latest improvements to Sweep:
  • New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
  • Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
  • Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

Copy link
Contributor Author

sweep-ai bot commented Mar 13, 2024

Rollback Files For Sweep

  • Rollback changes to README.md
  • Rollback changes to src/XmlWriter.php
  • Rollback changes to src/Services/XmlReader.php

This is an automated message generated by Sweep AI.

Copy link
Contributor Author

sweep-ai bot commented Mar 13, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

@curtisdelicata curtisdelicata merged commit 71d0310 into main Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant