feat: Updated 1 files

liberu-genealogy · May 12, 2024 · eb594b6 · eb594b6
1 parent 88c916b
commit eb594b6
Showing 1 changed file with 22 additions and 16 deletions.
diff --git a/src/Triangulation.php b/src/Triangulation.php
@@ -4,25 +4,31 @@
 
 class Triangulation {
 
-    public static function compareMultipleKits($kitsData) {
-        $snpsLists = array_map(function($kit) { return $kit->getSnps(); }, $kitsData);
-        $commonSnps = call_user_func_array('array_intersect_key', $snpsLists);
-        foreach ($commonSnps as $key => $snp) {
-            if (!self::isSnpCommonAcrossAllKits($snp, $kitsData)) {
-                unset($commonSnps[$key]);
-            }
-        }
-        return array_values($commonSnps);
+    public static function compareMultipleKits(array $kitsData): array {
+        $snpsLists = self::extractSnpLists($kitsData);
+        $commonSnps = self::findCommonSnps($snpsLists);
+        return self::filterNonCommonSnps($commonSnps, $kitsData);
     }
 
-    private static function isSnpCommonAcrossAllKits($snp, $kitsData) {
-        foreach ($kitsData as $kit) {
+    private static function extractSnpLists(array $kitsData): array {
+        return array_map(function($kit) { return $kit->getSnps(); }, $kitsData);
+    }
+
+    private static function findCommonSnps(array $snpsLists): array {
+        return call_user_func_array('array_intersect_key', $snpsLists);
+    }
+
+    private static function filterNonCommonSnps(array $commonSnps, array $kitsData): array {
+        return array_filter($commonSnps, function($snp) use ($kitsData) {
+            return self::isSnpCommonAcrossAllKits($snp, $kitsData);
+        });
+    }
+
+    private static function isSnpCommonAcrossAllKits(array $snp, array $kitsData): bool {
+        return count(array_filter($kitsData, function($kit) use ($snp) {
             $snps = $kit->getSnps();
-            if (!array_key_exists($snp['pos'], $snps) || $snps[$snp['pos']]['genotype'] !== $snp['genotype']) {
-                return false;
-            }
-        }
-        return true;
+            return isset($snps[$snp['pos']]) && $snps[$snp['pos']]['genotype'] === $snp['genotype'];
+        })) === count($kitsData);
     }
 }
 ?>