make verify fails with some dns test in 2.0.21

[shakaran]

Running make verify I get this in a Centos 6.3 machine:

Running tests:
EVPORT
Skipping test
KQUEUE
Skipping test
EPOLL
 test-eof: OKAY
 test-weof: OKAY
 test-time: OKAY
 test-changelist: OKAY
 regress: [Error code 3] 
  FAIL regress_dns.c:188: assert(dns_ok == DNS_PTR): 0 vs 2dns/gethostbyaddr: 
  FAIL regress_main.c:332: Legacy unit test failed
  [gethostbyaddr FAILED]
[Error code 3] 
  FAIL regress_dns.c:213: assert(dns_ok == DNS_PTR): 0 vs 2dns/resolve_reverse: 
  [resolve_reverse FAILED]

  FAIL regress_dns.c:1147: assert(n_dns == 2): 4 vs 2dns/bufferevent_connect_hostname: 
  [bufferevent_connect_hostname FAILED]
3/179 TESTS FAILED. (0 skipped)
FAILED
EPOLL (changelist)
 test-eof: OKAY
 test-weof: OKAY
 test-time: OKAY
 test-changelist: OKAY
 regress: [Error code 3] 
  FAIL regress_dns.c:188: assert(dns_ok == DNS_PTR): 0 vs 2dns/gethostbyaddr: 
  FAIL regress_main.c:332: Legacy unit test failed
  [gethostbyaddr FAILED]
[Error code 3] 
  FAIL regress_dns.c:213: assert(dns_ok == DNS_PTR): 0 vs 2dns/resolve_reverse: 
  [resolve_reverse FAILED]

  FAIL regress_dns.c:1147: assert(n_dns == 2): 4 vs 2dns/bufferevent_connect_hostname: 
  [bufferevent_connect_hostname FAILED]
3/179 TESTS FAILED. (0 skipped)
FAILED
DEVPOLL
Skipping test
POLL
 test-eof: OKAY
 test-weof: OKAY
 test-time: OKAY
 test-changelist: OKAY
 regress: [Error code 3] 
  FAIL regress_dns.c:188: assert(dns_ok == DNS_PTR): 0 vs 2dns/gethostbyaddr: 
  FAIL regress_main.c:332: Legacy unit test failed
  [gethostbyaddr FAILED]
[Error code 3] 
  FAIL regress_dns.c:213: assert(dns_ok == DNS_PTR): 0 vs 2dns/resolve_reverse: 
  [resolve_reverse FAILED]

  FAIL regress_dns.c:1147: assert(n_dns == 2): 4 vs 2dns/bufferevent_connect_hostname: 
  [bufferevent_connect_hostname FAILED]
3/179 TESTS FAILED. (0 skipped)
FAILED
SELECT
 test-eof: OKAY
 test-weof: OKAY
 test-time: OKAY
 test-changelist: OKAY
 regress: [Error code 3] 
  FAIL regress_dns.c:188: assert(dns_ok == DNS_PTR): 0 vs 2dns/gethostbyaddr: 
  FAIL regress_main.c:332: Legacy unit test failed
  [gethostbyaddr FAILED]
[Error code 3] 
  FAIL regress_dns.c:213: assert(dns_ok == DNS_PTR): 0 vs 2dns/resolve_reverse: 
  [resolve_reverse FAILED]

  FAIL regress_dns.c:1147: assert(n_dns == 2): 4 vs 2dns/bufferevent_connect_hostname: 
  [bufferevent_connect_hostname FAILED]
3/179 TESTS FAILED. (0 skipped)
FAILED
WIN32
Skipping test
FAIL: ../test/test.sh
==================
1 of 1 test failed

[nmathewson]

This is a known problem with some of the DNS unit tests in libevent 2.0 and earlier: They require particular behavior on the part of the local DNS resolver. The fix in Libevent 2.1 is not to run these particular tests by default.

[shakaran]

@nmathewson Thanks for your reply. if it is possible, could give me a more detailed explanation about the needed particular behaviour for the local DNS resolver? I would know what specific changes are needed in local DNS resolver for pass the test.

[nmathewson]

From the looks of it, your resolver isn't answering the PTR requests for the address 127.0.0.1. Those unit tests expect that the resolver will tell it some answer (ideally "localhost").

Personally, I would recommend instead that you skip this test or ignore the results if it isn't passing; it was IMO a mistake to have libevent

[jedisct1]

Thanks for spotting this.

The test has now been disabled.

[benlaurie]

You say this is disabled, yet I still see the same failure in 2.0.22.

[errzey]

One of the problems I noticed with anything client-dns test related is that we rely on our systems to be online and have a proper recursive setup somewhere that doesn't have any filtering.

I have been working on a test-plan to alleviate this problem. 2.1 is a good place for this to happen.

[errzey]

@benlaurie I think he's talking about in his project.

[azat]

AFAIU 2.1 doesn't have this issue, can we close this or we want this fixed in 2.0?

[azat]

Closing this one, if somebody thinks that this must be fixed in 2.0, please reopen!