Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmlparse.c: Fix NULL pointer dereference in setContext via XML_ExternalEntityParserCreate for XML_DTD undefined #780

Merged
merged 1 commit into from
Oct 24, 2023
Merged

xmlparse.c: Fix NULL pointer dereference in setContext via XML_ExternalEntityParserCreate for XML_DTD undefined #780

merged 1 commit into from
Oct 24, 2023

Conversation

hartwork
Copy link
Member

@hartwork hartwork commented Oct 23, 2023 •
edited

@hartwork
xmlparse.c: Fix NULL pointer dereference in XML_ExternalEntityParserC…
4eeaf49 
…reate

.. for context NULL inside function setContext
when macro XML_DTD is not defined at compile time.
@hartwork hartwork added the bug label Oct 23, 2023
@hartwork hartwork added this to the 2.6.0 milestone Oct 23, 2023
@hartwork hartwork mentioned this pull request Oct 23, 2023
Merged
35 tasks
@hartwork hartwork changed the title xmlparse.c: Fix NULL pointer dereference in XML_ExternalEntityParserCreate xmlparse.c: Fix NULL pointer dereference in setContext via XML_ExternalEntityParserCreate for XML_DTD undefined Oct 23, 2023
Snild-Sony
Snild-Sony approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@Snild-Sony Snild-Sony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, there is no way to trigger this problem without API misuse, but I guess it doesn't hurt to fix it either.

@hartwork
Copy link
Member Author

@Snild-Sony thanks for the review!

@hartwork hartwork merged commit 9e1c413 into master Oct 24, 2023
62 checks passed
@hartwork hartwork deleted the xml-dtd-undefined-fix-ext-parser-create-null-dereference branch October 25, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snild-Sony Snild-Sony Snild-Sony approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hartwork @Snild-Sony