tests: Stop switching between XML_Parse and _XML_Parse_SINGLE_BYTES #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartwork
requested changes
Oct 25, 2023
There was a problem hiding this comment.
@Snild-Sony thanks for the pull request! Two details seem off, please see below:
35 tasks
Since commit 091ba48 ("tests: Run SINGLE_BYTES with no chunking"), all tests are run an extra time with SINGLE_BYTES set to perform just a single XML_Parse() call. There is no longer a need for individual tests to switch between them.
All tests now run one instance where SINGLE_BYTES is equivalent to a single XML_Parse call. There is no longer a need for individual tests to switch between them.
All tests now run one instance where SINGLE_BYTES is equivalent to a single XML_Parse call. Using SINGLE_BYTES therefore gives more coverage, as evidenced by the new failure we now have to avoid in the test, until it can be fixed.
Snild-Sony
force-pushed
the
remove-singlebytes-switching
branch
from
7c2ea8b
to
1222ae3
Compare
hartwork
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
@Snild-Sony thanks for the adjustments! 👍 Ready to merge if the CI likes it, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 091ba48, all tests are also run with chunkSize=0, which makes _XML_Parse_SINGLE_BYTES behave like XML_Parse.
Some tests were already using loops or conditions to switch between the two. This is no longer necessary.