Make GitHub Actions enforce clang-tidy clean code + address current clang-tidy warnings #798
Conversation
clang-tidy output was: > [..]/examples/element_declarations.c:163:16: warning: Potential leak of memory pointed to by 'stackTop' [clang-analyzer-unix.Malloc] > 163 | return false; > | ^
expat/xmlwf/xmlmime.c
Outdated
| @@ -135,6 +135,8 @@ getXMLCharset(const char *buf, char *charset) { | |||
| if (0) { | |||
| if (! matchkey(p, next, "xml") && charset[0] == '\0') | |||
| return; | |||
| } else { | |||
| (void)p; | |||
There was a problem hiding this comment.
There is an UNUSED_P() macro which is already used in xmlwf.c, so could also be used here.
...however, it's defined in lib/internal.h, which is not very nice to include from outside the lib. xmlwf.c says /* for UNUSED_P only */ at the include, but it's easy to miss/forget.
There was a problem hiding this comment.
@Snild-Sony thanks for having a look! I should note that xmlmime.c is one of the unused files that #119 is about, it is not compiled by either of the two build systems today. Let me revert this change and point to #119 right above the list of excluded files in script apply-clang-tidy.sh where I'll add xmlmime.c for exclusion also. The original idea was to keep the exclusion list as short as possible (and this small change allowed the list to be shorter) but if xmlmime.c does not even see a compiler and its warnings, maybe it should be excluded from clang-tidy instead until #119 finds some decision.
.. where stackTop is NULL anyway
…NullParamChecker clang-tidy output was: > [..]/tests/acc_tests.c:368:9: warning: Null pointer passed to 1st parameter expecting 'nonnull' [clang-analyzer-core.NonNullParamChecker] > 368 | if (strlen(printable) < (size_t)1) > | ^ ~~~~~~~~~ Note: It was harmless because fail(..) right before catches that case.
…ullDereference clang-tidy output was: > [..]/tests/basic_tests.c:2083:19: warning: Dereference of null pointer [clang-analyzer-core.NullDereference] > 2083 | errorFlags |= ((model[0].type == XML_CTYPE_SEQ) ? 0 : (1u << 2)); > | ^~~~~~~~~~~~~
No description provided.