Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--includedir is ignored #459

Closed
rofl0r opened this issue Nov 15, 2018 · 10 comments
Closed

--includedir is ignored #459

rofl0r opened this issue Nov 15, 2018 · 10 comments

Comments

@rofl0r
Copy link
Contributor

rofl0r commented Nov 15, 2018

System Details

x86_64-unknown-linux-gnu

Problems Description

i pass --prefix=/usr/local --includedir=/usr/local/include, yet the includefiles end up in /usr/local/lib/libffi-3.0.2/include

@JL2210
Copy link

JL2210 commented Dec 16, 2018

I'm not a maintainer of this project, but this issue has been going around for a long time. Try to pass --oldincludedir and if that doesn't work, manually copy the files: cp -a /usr/local/lib/libffi-3.0.2/include/. /usr/local/include. You really should be using the newer releases, however.

@rofl0r
Copy link
Contributor Author

rofl0r commented Dec 16, 2018

You really should be using the newer releases, however.

instead, i think the project here should really be following the rules and respecting the choices of the users, especially when it's choices their build system offers.

@tromey
Copy link
Member

tromey commented Dec 16, 2018

I couldn't easily find where this is done, but I think this is a side effect of libffi's unusual multilib setup. I tend to think it would be better to move to a more normal configure system (and let gcc deal with the multilib stuff), but this sort of change would require some agreement from other parties on the mailing list.

@JL2210
Copy link

JL2210 commented Dec 16, 2018

@rofl0r, I'm sorry. I just noticed that you were using release 3.0.2 and that the latest stable release was 3.2.1.
@tromey I think that Libtool could work to circumvent this. Could you please look into it?

@JL2210
Copy link

JL2210 commented Dec 16, 2018

Possibly try configuring with --disable-multi-os-directory?

@pnallan
Copy link
Contributor

pnallan commented Jul 5, 2019

@rofl0r @atgreen , This is not seen in latest release .
I verified same on Clearlinux & issue not seen in latest release.
Kindly close this ticket.

Log:
x86_64-pc-linux-gnu
$./configure --prefix=/usr/local --includedir=/usr/local/include
/libffi_prj/libffi $ ls /usr/local/include/
dejagnu.h ffi.h ffitarget.h libftdi1 python2.7 python3.7m

@rofl0r
Copy link
Contributor Author

rofl0r commented Jul 5, 2019

$ ls /usr/local/include/
dejagnu.h ffi.h ffitarget.h libftdi1 python2.7 python3.7m

that doesn't look right. there should be a dir like libffi-3.0.2 inside /usr/local/include.

@pnallan
Copy link
Contributor

pnallan commented Jul 9, 2019

$ ls /usr/local/include/
dejagnu.h ffi.h ffitarget.h libftdi1 python2.7 python3.7m

that doesn't look right. there should be a dir like libffi-3.0.2 inside /usr/local/include.

As per my knowledge its not necessary to create directory. If you create directory while writing examples need to specify folder name in the files.
Seems owner defined like this to common for all users & correct me if i am wrong.

@rofl0r
Copy link
Contributor Author

rofl0r commented Jul 9, 2019

it used to be like that, at least. and it makes sense to put all ffi headers into a common directory, so you can do something like #include <ffi/whatever.h>, just like e.g. SDL. what makes less sense is hardcoding a version number into the directory prefix though, as it prevents just that.

@atgreen
Copy link
Member

atgreen commented Dec 7, 2019

I'm closing this, as per @pnallan . Please re-open if you disagree.

@atgreen atgreen closed this as completed Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants