Fix -Wsign-compare warnings in x86/ffi64.c #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -350,7 +350,7 @@ examine_argument (ffi_type *type, enum x86_64_reg_class classes[MAX_CLASSES], | |||
| _Bool in_return, int *pngpr, int *pnsse) | |||
| { | |||
| size_t n; | |||
| int i, ngpr, nsse; | |||
| unsigned int i, ngpr, nsse; | |||
There was a problem hiding this comment.
This changes the type of ngpr and nsse, but those are later assigned like *pngpr = ngpr; -- where pngpr is a pointer-to-int.
There was a problem hiding this comment.
Thanks for the review. I've now updated the patch.
This was originally reported on the Python tracker: httpa://bugs.python.org/issue23958 The original patch was written by Steve R. Hastings. I've updated it to current master of libffi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally reported on the Python tracker:
https://bugs.python.org/issue23958
The original patch was written by Steve R. Hastings.
I've updated it to current master of libffi.