Don't use FFI_TYPE_LONGDOUBLE in the jump table in win64*.S #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may have the same value as FFI_TYPE_DOUBLE per ffi.h, which possibly can make things go wrong with .org/ORG. For instance, GCC complains about "Error: attempt to move .org backwards"
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 22, 2020
All the patches previously applied, except the one from bug 1279096, are either irrelevant (as pertaining to changes to the upstream build system we don't use anymore), were applied upstream, or the issue they fixed were fixed differently upstream. Two additional patches, sent upstream as libffi/libffi#579 and libffi/libffi#580, are needed to fix our build with, respectively, mingw-clang and GCC. Our build system is adjusted according to upstream's configure.ac and configure.host. Differential Revision: https://phabricator.services.mozilla.com/D87824
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 23, 2020
All the patches previously applied, except the one from bug 1279096, are either irrelevant (as pertaining to changes to the upstream build system we don't use anymore), were applied upstream, or the issue they fixed were fixed differently upstream. Two additional patches, sent upstream as libffi/libffi#579 and libffi/libffi#580, are needed to fix our build with, respectively, mingw-clang and GCC. Our build system is adjusted according to upstream's configure.ac and configure.host. Differential Revision: https://phabricator.services.mozilla.com/D87824
ambroff
pushed a commit
to ambroff/gecko
that referenced
this pull request
Nov 4, 2020
All the patches previously applied, except the one from bug 1279096, are either irrelevant (as pertaining to changes to the upstream build system we don't use anymore), were applied upstream, or the issue they fixed were fixed differently upstream. Two additional patches, sent upstream as libffi/libffi#579 and libffi/libffi#580, are needed to fix our build with, respectively, mingw-clang and GCC. Our build system is adjusted according to upstream's configure.ac and configure.host. Differential Revision: https://phabricator.services.mozilla.com/D87824
ambroff
pushed a commit
to ambroff/gecko
that referenced
this pull request
Nov 4, 2020
All the patches previously applied, except the one from bug 1279096, are either irrelevant (as pertaining to changes to the upstream build system we don't use anymore), were applied upstream, or the issue they fixed were fixed differently upstream. Two additional patches, sent upstream as libffi/libffi#579 and libffi/libffi#580, are needed to fix our build with, respectively, mingw-clang and GCC. Our build system is adjusted according to upstream's configure.ac and configure.host. Differential Revision: https://phabricator.services.mozilla.com/D87824
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may have the same value as FFI_TYPE_DOUBLE per ffi.h, which
possibly can make things go wrong with .org/ORG.
For instance, GCC complains about "Error: attempt to move .org
backwards"