Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac: allow user to specify READELF #646

Merged
merged 1 commit into from
Jun 26, 2021
Merged

configure.ac: allow user to specify READELF #646

merged 1 commit into from
Jun 26, 2021

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jun 26, 2021

Before the change with x86_64-pc-linux-gnu cross-compiler
installed the configure was not able to find cross-readelf:

$ ./configure --host=x86_64-pc-linux-gnu
...
checking whether .eh_frame section should be read-only... .././configure: line 19540: readelf: command not found
yes
...

The change uses AC_CHECK_TOOL to automatically seatch for ${host}-readelf,
readelf. And as a bonus it also allows user to override readelf with
something like READELF=llvm-readelf.

Before the change with x86_64-pc-linux-gnu cross-compiler
installed the configure was not able to find cross-readelf:

```
$ ./configure --host=x86_64-pc-linux-gnu
...
checking whether .eh_frame section should be read-only... .././configure: line 19540: readelf: command not found
yes
...
```

The change uses AC_CHECK_TOOL to automatically seatch for ${host}-readelf,
readelf. And as a bonus it also allows user to override readelf with
something like READELF=llvm-readelf.

Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
@atgreen
Copy link
Member

atgreen commented Jun 26, 2021

This is great - thanks.

@atgreen atgreen merged commit f792adb into libffi:master Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants