Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powerpc64: fix handling of homogeneous float128 structs #689

Merged
merged 1 commit into from Jan 31, 2022

Conversation

sharkcz
Copy link
Contributor

@sharkcz sharkcz commented Jan 31, 2022

If there is a homogeneous struct with float128 members, they should be
copied to vector register save area. The current code incorrectly copies
only the value of the first member, not increasing the pointer with each
iteration. Fix this.

If there is a homogeneous struct with float128 members, they should be
copied to vector register save area. The current code incorrectly copies
only the value of the first member, not increasing the pointer with each
iteration. Fix this.
@sharkcz
Copy link
Contributor Author

sharkcz commented Jan 31, 2022

Related: https://bugzilla.redhat.com/show_bug.cgi?id=2045797

Without the fix there are 2 test failures when GCC defaults to IEEE Float128 type for long double.

...
Running ../../testsuite/libffi.call/call.exp ...
Running ../../testsuite/libffi.closures/closure.exp ...
FAIL: libffi.closures/cls_align_longdouble_split.c -W -Wall -Wno-psabi -O0 execution test
FAIL: libffi.closures/cls_align_longdouble_split.c -W -Wall -Wno-psabi -O2 execution test
Running ../../testsuite/libffi.complex/complex.exp ...
Running ../../testsuite/libffi.go/go.exp ...

		=== libffi Summary ===

# of expected passes		1466
# of unexpected failures	2
# of unsupported tests		28
make[3]: *** [Makefile:457: check-DEJAGNU] Error 1

@sharkcz
Copy link
Contributor Author

sharkcz commented Jan 31, 2022

@wschmidt-ibm, could you review it, please?

@atgreen atgreen merged commit 464b4b6 into libffi:master Jan 31, 2022
@wschmidt-ibm
Copy link

Thank you, Dan! LGTM (and I see it is merged). Much obliged for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants