New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A more robust blend? #105
Comments
I think that the standard library should take the slower-but-better option by default. The commit above makes the default (If you want to go overboard, you could also add an optional |
Did you mean to leave |
Anyway, a bigger issue is -- for some reason, That's the only reason I was using |
I'm (slightly) breaking backwards compatibility here, by making Your attached example is a case where auto-bounds failed, and the bounds fall back to the default (global) bounds, which don't contain the full shape. I think everything is working as designed, except that we need better UI indications for when autobounds failed (and obviously autobounds could be more robust). |
Oh whoops, sorry, I read that too quickly, you're right (about About the auto-bounds thing, though: my point is that auto-bounds is consistently failing on |
Just checking in here to make sure you're aware that |
Yes, I'm aware, but haven't thought about how to fix it – I think the structure of What do you think – should we make |
If I can do a pull for it -- do you think I should have the function automatically apply my conversion to make it produce roughly similar outputs for the same smoothing values, just to ease the transition (and let people more easily switch between them)? (Maybe I can add a |
Also: should I just get rid of |
Quick question: why is |
Also: what makes the shape reference listing describe |
I ran into a case recently where the default blend method was producing weird artifacts, but a different blend method didn't:
and I'm tempted to offer
smin-exponential
as a replacement forblend
, but the fact is it runs about 50% slower, and I'm not sure if that would be worth it for something that works fine in most cases. Instead maybe I could add it asblend-precise
or something, for people to manually switch to when they've found that a shape they've blended is acting glitchy?The other thing is that
smin-exponential
takes a number that produces a sharp result with large numbers and a smoother result the closer it gets to 1, i.e. something that would map more closely to(/ m)
compared with howblend
works... and I'm getting reasonably close at getting the two functions to produce similar results for smoothing values under 1 (my best result islet ((k (/ (expt (/ k 2.4) 1.2))))
), but I they're never quite going to produce the same result, and I'm wondering whether it's worth trying to map them similarly like this, or if it would be better to just inform people that they take different input values and let them find the new value they want, rather than implying that it could be similar.(I think I've mentioned this before, but just for the record, I'm getting these algorithms from here: http://www.iquilezles.org/www/articles/smin/smin.htm )
The text was updated successfully, but these errors were encountered: