New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naive attempt at handling nofail #221

Merged
merged 1 commit into from Dec 1, 2017

Conversation

Projects
None yet
2 participants
@jsoref
Contributor

jsoref commented Nov 23, 2017

issue #211

I have no idea if this will work. But is this the right file/direction?

@Nikratio

This comment has been minimized.

Show comment
Hide comment
@Nikratio

Nikratio Nov 23, 2017

Contributor

That really depends on what you are trying to achieve. Maybe you could elaborate on your goals?

Contributor

Nikratio commented Nov 23, 2017

That really depends on what you are trying to achieve. Maybe you could elaborate on your goals?

@Nikratio Nikratio added the needs-info label Nov 23, 2017

@Nikratio

This comment has been minimized.

Show comment
Hide comment
@Nikratio

Nikratio Nov 23, 2017

Contributor

Sorry, just saw the issue reference. No, this is the wrong way to do it. As the issue says, this needs to be filtered out in the mount helper.

Contributor

Nikratio commented Nov 23, 2017

Sorry, just saw the issue reference. No, this is the wrong way to do it. As the issue says, this needs to be filtered out in the mount helper.

@jsoref

This comment has been minimized.

Show comment
Hide comment
@jsoref

jsoref Nov 23, 2017

Contributor

@Nikratio: where is that?

Contributor

jsoref commented Nov 23, 2017

@Nikratio: where is that?

@Nikratio

This comment has been minimized.

Show comment
Hide comment
@jsoref

This comment has been minimized.

Show comment
Hide comment
@jsoref

jsoref Nov 26, 2017

Contributor

@Nikratio: how's this?

Contributor

jsoref commented Nov 26, 2017

@Nikratio: how's this?

@Nikratio

This comment has been minimized.

Show comment
Hide comment
@Nikratio

Nikratio Nov 27, 2017

Contributor

Doesn't look right to me. Why do you think the presence of nofail should affect the exit code?

Contributor

Nikratio commented Nov 27, 2017

Doesn't look right to me. Why do you think the presence of nofail should affect the exit code?

@jsoref

This comment has been minimized.

Show comment
Hide comment
@jsoref

jsoref Nov 27, 2017

Contributor

Sorry. The documentation for this stuff is more or less vaporous. nofail definitely affects someone's handling of an error status. But, I think you're right, it's just the caller's understanding of the error status, not the callee.

I'll try to post the obvious/simpler fix (closer to my original, but for this file) tonight.

Contributor

jsoref commented Nov 27, 2017

Sorry. The documentation for this stuff is more or less vaporous. nofail definitely affects someone's handling of an error status. But, I think you're right, it's just the caller's understanding of the error status, not the callee.

I'll try to post the obvious/simpler fix (closer to my original, but for this file) tonight.

@jsoref

This comment has been minimized.

Show comment
Hide comment
@jsoref

jsoref Nov 27, 2017

Contributor

@Nikratio : how about this? :)

Contributor

jsoref commented Nov 27, 2017

@Nikratio : how about this? :)

@Nikratio

This comment has been minimized.

Show comment
Hide comment
@Nikratio

Nikratio Nov 29, 2017

Contributor

Looks good! Now just add a ChangeLog entry for this.

Contributor

Nikratio commented Nov 29, 2017

Looks good! Now just add a ChangeLog entry for this.

@jsoref

This comment has been minimized.

Show comment
Hide comment
@jsoref

jsoref Nov 30, 2017

Contributor

@Nikratio : done

Contributor

jsoref commented Nov 30, 2017

@Nikratio : done

@Nikratio Nikratio merged commit a83cd72 into libfuse:master Dec 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsoref jsoref deleted the jsoref:nofail branch Dec 2, 2017

@jsoref jsoref restored the jsoref:nofail branch Dec 2, 2017

@jsoref jsoref deleted the jsoref:nofail branch Dec 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment