Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naive attempt at handling nofail #221

Merged
merged 1 commit into from Dec 1, 2017
Merged

Naive attempt at handling nofail #221

merged 1 commit into from Dec 1, 2017

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 23, 2017

issue #211

I have no idea if this will work. But is this the right file/direction?

@Nikratio
Copy link
Contributor

That really depends on what you are trying to achieve. Maybe you could elaborate on your goals?

@Nikratio
Copy link
Contributor

Sorry, just saw the issue reference. No, this is the wrong way to do it. As the issue says, this needs to be filtered out in the mount helper.

@jsoref
Copy link
Contributor Author

jsoref commented Nov 23, 2017

@Nikratio: where is that?

@Nikratio
Copy link
Contributor

@jsoref
Copy link
Contributor Author

jsoref commented Nov 26, 2017

@Nikratio: how's this?

@Nikratio
Copy link
Contributor

Doesn't look right to me. Why do you think the presence of nofail should affect the exit code?

@jsoref
Copy link
Contributor Author

jsoref commented Nov 27, 2017

Sorry. The documentation for this stuff is more or less vaporous. nofail definitely affects someone's handling of an error status. But, I think you're right, it's just the caller's understanding of the error status, not the callee.

I'll try to post the obvious/simpler fix (closer to my original, but for this file) tonight.

@jsoref
Copy link
Contributor Author

jsoref commented Nov 27, 2017

@Nikratio : how about this? :)

@Nikratio
Copy link
Contributor

Looks good! Now just add a ChangeLog entry for this.

@jsoref
Copy link
Contributor Author

jsoref commented Nov 30, 2017

@Nikratio : done

@Nikratio Nikratio merged commit a83cd72 into libfuse:master Dec 1, 2017
@jsoref jsoref deleted the nofail branch December 2, 2017 23:28
@jsoref jsoref restored the nofail branch December 2, 2017 23:28
@jsoref jsoref deleted the nofail branch December 2, 2017 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants