Replace fork by posix_spawn in mount_util.c #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This completes commit bb9cecb ("Use posix_spawn instead of fork+exec") and replaces remaining fork by posix_spawn. Not modified is mount_bsd.d as I cannot test it.
This adds the env FUSE_NO_MTAB_UPDATE variable to be able to disable mtab updates without recompiling libfuse. The value needs to be set to 1. This is an addition to commit 74b1df2, which removed a check for mtab updates, if mtab is a symlink. Although not related to the symlink, this caused a regression in our code, as the symlink update was done through fork. The env variable is a run time workaround for such cases and to avoid the requirement to disable mtab updates at libfuse configuration/compilation time.
bsbernd
force-pushed
the
mount-util-posix_spawn
branch
from
bdb8d57
to
d9f86e7
Compare
trapexit
reviewed
Mar 14, 2024
|
|
||
| int flags = POSIX_SPAWN_RESETIDS | POSIX_SPAWN_SETSIGMASK; | ||
| res = posix_spawnattr_setflags(attr, flags); | ||
| if (res) { |
There was a problem hiding this comment.
Why the difference between this check and the one on line 110? From the man pages both appear to return 0 on success and an errno on error.
There was a problem hiding this comment.
Thanks, the check below for (res < 0) needs to be fixed. Although I see it in line 103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes commit bb9cecb
("Use posix_spawn instead of fork+exec") and replaces remaining
fork by posix_spawn.
Not modified is mount_bsd.d as I cannot test it.
Another commit adds the env FUSE_NO_MTAB_UPDATE to be able to
disable mtab updates without recompilation.