fuse_session_custom_io: Add a struct size field #930
Conversation
As in commit 73cd124 'struct fuse_custom_io' might get extended and in order to stay ABI compatible libfuse has to zero all extended fields. In order to do so it has to know the size of the struct the application knows about. Signed-off-by: Bernd Schubert <bernd.schubert@fastmail.fm>
There was a problem hiding this comment.
This looks good.
As I say it might be possible to support two versions in the same way we do at
https://github.com/libfuse/libfuse/blob/master/include/fuse_lowlevel.h#L1979-L1992 but I'd need to look into that. This solves the problem for master and going forward at least.
|
Yeah, we can make it versioned (ABI and API). I cannot work on that right now, probably earliest tomorrow morning. I would also happily let you do the versioning part - if you want :) |
sorry I missed this. I'll have a go in the morning. |
|
Thanks Ashley! My patch to get the libfuse version passed into fuse_session_new is growing and got me busy for spare time over the weekend. Difficulty is the highlevel API. I hope I'm close to get that done, but then didn't have any time for this issue here. |
|
This patch looks good to me, thanks for your time. I didn't realize this compatibility issue before, sorry. |
|
@legezywzh The patch is unfortunately not complete - we need to ensure API and ABI compatibility and that makes it more complex. |
So the correct solution is #935, right? I'll take a look. |
|
Yeah, but it is not complete yet. |
|
Already addressed here: #953 |
As in commit 73cd124 'struct fuse_custom_io' might get extended and in order to stay ABI compatible libfuse has to zero all extended fields. In order to do so it has to know the size of the struct the application knows about.