Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdImageRotate functions don't take a ignoretransparent flag #103

Open
imazen-bot opened this issue Feb 5, 2015 · 4 comments
Open

gdImageRotate functions don't take a ignoretransparent flag #103

imazen-bot opened this issue Feb 5, 2015 · 4 comments
Assignees
@pierrejoye
Labels
enhancement

Comments

@imazen-bot
Copy link

3 functions do:

  • gdImageRotate90
  • gdImageRotate180
  • gdImageRotate270

but 5 do not:

  • gdImageRotateNearestNeighbour
  • gdImageRotateBilinear
  • gdImageRotateBicubicFixed
  • gdImageRotateGeneric
  • gdImageRotateInterpolated

PHP exposes this param to users and currently just ignores it.
http://www.php.net/manual/en/function.imagerotate.php
@vapier vapier mentioned this issue Jan 11, 2016
Closed
@pierrejoye
Copy link
Contributor

These functions will be removed, everything is done using gd_interpolation.

Leave that one open until we moved the 90 degrees-like function to gd_interpolation.c.

@pierrejoye pierrejoye added this to the GD-2.2.3 milestone Jun 24, 2016
@pierrejoye pierrejoye self-assigned this Jun 24, 2016
@pierrejoye pierrejoye removed this from the GD-2.2.3 milestone Jul 19, 2016
@pierrejoye
Copy link
Contributor

This can wait 2.2.4 or 2.3.0, no bug so far.

@vapier
Copy link
Member

vapier commented Jul 22, 2016

i'm fine with leaving this kind of work for 2.3. i think 2.2 should focus on bug fixes only.

@cmb69
Copy link
Contributor

cmb69 commented Oct 3, 2016

Certainly that's not a bug for libgd, but it is a bug for the PHP bindings, so I hope this enhancement will come soon. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierrejoye pierrejoye

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vapier @pierrejoye @cmb69 @imazen-bot