Fix 248 #251
Fix 248 #251
Conversation
|
@cmb69 Please review, if you have a tad bit time. |
| for (i = 0; i < encoded_pixels; i++) { | ||
| for (j = 0; j < pixel_block_size; j++, bitmap_caret++) { | ||
| tga->bitmap[ bitmap_caret ] = decompression_buffer[ buffer_caret + j ]; | ||
| if (encoded_pixels > 0) { |
There was a problem hiding this comment.
encoded_pixels is declared as uint8_t, so this would always be true. Either the if statement is useless, or it should be encoded_pixels < 128. Same issue below.
There was a problem hiding this comment.
Nope, it won't be always true, but it could be changed to if (encoded_pixels != 0) for clarity. (It might also be an useless optimization as encoded_pixels would be always != 0 in normal case).
There was a problem hiding this comment.
Nope, it won't be always true, […]
Of course! Sorry for the noise.
There was a problem hiding this comment.
I changed it to != 0 anyway to make more clear (although I suspect any decent compiler would do that for me anyway).
oerdnj
force-pushed
the
fix-248
branch
2 times, most recently
from
4e952ed
to
388ee78
Compare
|
While I assumed that bug00248.tga is corrupt, both Gimp and Imagick's display open it without warning (contrary to bug00247.tga). Not sure, if Gimp and Imagick do advanced error correction here. |
fixes output buffer overflow in #248