gdImageGd2Ptr memory leak

[meweez]

We discussed it in issue #700.

There are some conditions in _gdImageGd2 which lead it to fail1. So if it goes through these fail situations it means that the out isn't allocated correctly and calling the gdDPExtractData leads to double free.
so I add return value to _gdImageGd2 and checked it in gdImageGd2Ptr.

[pierrejoye]

Thanks for the updated PR!

Could you push a change (no matter which) to see if all tests pass on all platforms? We finally have gh actions with Linux/MacOS/Windows (ARM and co coming too).

[meweez]

Could you push a change (no matter which) to see if all tests pass on all platforms?

sorry, I don't understand that what to do now?

[pierrejoye]

like commit and push a white space change to trigger the github actions :)

[pierrejoye]

Seems some weird non printable bytes made it in :)

[meweez]

there is an error in " Windows 2019 x64" with this message "libheif version found is too old".

is this because of some mistakes in the commit?

[pierrejoye]

let me fix it. Did you see the Linux one?

…

On Tue, Aug 24, 2021, 2:51 PM Maryam Ebrahimzadeh ***@***.***> wrote: there is an error in " Windows 2019 x64" with this message "libheif version found is too old". — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#713 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACE6KEACL4JF42QXKNWL6DT6NFQLANCNFSM5AT2BYUQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[meweez]

Did you see the Linux one?

I fixed that and remove non-printable bytes. It is successful.
Now there is a problem only with windows.

[pierrejoye]

it should be good now. I re run the jobs :)

…

On Tue, Aug 24, 2021, 3:46 PM Maryam Ebrahimzadeh ***@***.***> wrote: Did you see the Linux one? I fixed that and remove non-printable bytes. Now there is a problem only with windows. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#713 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACE6KAHTRTBZBNWOLN2KLLT6NL5ZANCNFSM5AT2BYUQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[meweez]

it should be good now

Again the same error with libheif.

[pierrejoye]

It should be ok. That HEIF issue works now and is not related to your PR.

[meweez]

is not related to your PR.

Ok, so can you merge this PR?

[pierrejoye]

thank you :) I will merge it later today :)

…

On Tue, Aug 24, 2021, 4:09 PM Maryam Ebrahimzadeh ***@***.***> wrote: is not related to your PR. Ok, so can you merge this PR? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#713 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACE6KB5O5HTGLTKEZPVA53T6NOWLANCNFSM5AT2BYUQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .